Wealthy Americans left New York in droves two years ago as the city continues to grapple with an exodus of high-income earners leaving for lower-tax destinations.